WC3 JASS.com
"The Jass Vault" plus vJASS and Zinc

moyack · **on:** October 03, 2012, 05:11:31 AM

Description

The purpose of this library is to offer a set of basic functions which will help in the fast and proper development of code.

Here we focus in the usage of groups of units, which usually are managed via groupenum + a function that handles those units. This has proven to be inneficient and we are now offering a set of modules which will do the firstofgroup approach, giving a faster writing to this process.

Requirements

- None

Actual code

Code: jass

/******************************************************************
*                   GROUP HANDLER LIBRARY V1.0                    *
*                           By moyack                             *
*                              2012                               *
*              ===================================                *
*              Exclusive resource from wc3jass.com                *
*              ===================================                *
******************************************************************/
library GroupLoopHandler
/* The purpose of this library is to offer a set of basic functions
which will help in the fast and proper development of code.
 
Here we focus in the usage of groups of units, which usually are
managed via groupenum + a function that handles those units. This
has proven to be inneficient and we are now offering a set of modules
which will do the firstofgroup approach, giving a faster writing 
to this process.*/
 
globals
    public unit U = null
endglobals
 
constant function GetLoopingUnit takes nothing returns unit 
    return U
endfunction
 
//! textmacro GroupLoop
    call GroupEnumUnitsInRange(bj_lastCreatedGroup, 0, 0, 999999999., null)
    loop
        set GroupLoopHandler_U = FirstOfGroup(bj_lastCreatedGroup)
        exitwhen GetLoopingUnit() == null
//! endtextmacro
 
//! textmacro EndGroupLoop
        call GroupRemoveUnit(bj_lastCreatedGroup, GetLoopingUnit())
    endloop
//! endtextmacro
 
endlibrary

Example

Code: jass

library test requires GroupLoopHandler
 
private function test takes nothing returns nothing
    //! runtextmacro GroupLoop()
        call DisplayTimedTextFromPlayer(Player(0), 0,0,3,R2S(GetUnitX(GetLoopingUnit())))
    //! runtextmacro EndGroupLoop()
endfunction
 
endlibrary

Could exist a beeter way to do it?? at least nicer? textmacros looks horrible. I'd like that module works in this case

Comments and HUGE suggestions are always welcome.

Purgeandfire · **Reply #1 on:** October 04, 2012, 09:52:40 PM

Hmm... Wouldn't this have some problems in bigger maps? As in, you would end up having to iterate through tons of units.

Textmacros work. I don't think you necessarily have to switch to modules--the declaration looks nicer but textmacros have a bit more functionality to it.

Anyway, is this meant to be used for all grouping purposes? Or just grouping in range?

Also, perhaps you shouldn't use bj_lastCreatedGroup. I know GUI users won't use this but it might be better to just have a global group just in case.

Troll-Brain · **Reply #2 on:** October 05, 2012, 11:42:40 AM

What's wrong with the for loop of Cohadar's jasshelper ?

for <unitVariable> in <groupVariable>
// do your stuff with "unitVariable"
endfor

moyack · **Reply #3 on:** October 06, 2012, 06:15:37 AM

Quote from: Purgeandfire on October 04, 2012, 09:52:40 PM

Hmm... Wouldn't this have some problems in bigger maps? As in, you would end up having to iterate through tons of units.

I was thinking that the maximum units in a map shouldn't be more than 8000, but yes I shouldn't assume anything.

Quote

Textmacros work. I don't think you necessarily have to switch to modules--the declaration looks nicer but textmacros have a bit more functionality to it.

Yes... ok... sniff

Quote

Anyway, is this meant to be used for all grouping purposes? Or just grouping in range?

Right, the idea is that inside the Grouploop and endGroupLoop you do the conditionals for filtering all the units.

Quote

Also, perhaps you shouldn't use bj_lastCreatedGroup. I know GUI users won't use this but it might be better to just have a global group just in case.

me and my idea to reduce handle count

Quote from: Troll-Brain on October 05, 2012, 11:42:40 AM

What's wrong with the for loop of Cohadar's jasshelper ?

for <unitVariable> in <groupVariable>
// do your stuff with "unitVariable"
endfor

Man, the problem is now called ME!!! That's the thing that I need in this library. The only "flaw" is that it can't be compiled in vexorian JH, but we're avoiding it, so... What the hell!!!!

Graveyarded