Warcraft 3 documentation

vJASS & Zinc Documentation
For the latest documentation about how it works vJASS and Zinc language layers for Warcraft III, please follow these links:
Jasshelper documentation - Zinc documentation - WC3 Optimizer documentation

Can I request some help please? :)

Lazerus · 14895

0 Members and 1 Guest are viewing this topic.

Can I request some help please? :)
on: May 22, 2015, 09:10:46 PM

I am helping a friend edit a well known map with permission and I am running into some problems with the editor plugins that this map uses. I am well versed in GUI but not vJass. Every time I add a new trigger and try to open the map with wc3 it won't load. JNGP 2.0 ALPHA, with UMSWE enabled. Thank you.



Re: Can I request some help please? :)
Reply #1 on: May 23, 2015, 09:39:16 AM

UMSWE is the issue most the times. This modification has been kept just to allow the opening of old maps done with this mod.

The right process is to start with a copy of the map and convert all the trigger to custom text, with this, you "override" the USMWE blocking imposed by the trigger editor and then you can start the process of vJASSification.

Now the question is: what kind of errors are you getting?? screenshots are helpful in this case.


Re: Can I request some help please? :)
Reply #2 on: May 23, 2015, 10:10:37 AM

Okay, thanks. Hey, is there a tool used to convert to custom text I have never done that?



Re: Can I request some help please? :)
Reply #3 on: May 23, 2015, 10:19:05 AM

Okay, thanks. Hey, is there a tool used to convert to custom text I have never done that?

No problem, the WE itself does the job. Just select the trigger and then convert it into custom code via Edit > Convert to Custom Text.


Re: Can I request some help please? :)
Reply #4 on: May 23, 2015, 10:32:51 AM

Booom your the man thank you. I knew it was in there somewhere...

"Good ol'WE, my old friend I have been away far to long." -me



Re: Can I request some help please? :)
Reply #5 on: May 23, 2015, 10:52:14 AM

Unfortunately that didn't work... maybe there is a problem with the trigger?
Code: [Select]
function Trig_detonate_Conditions takes nothing returns boolean
    if ( not ( GetUnitTypeId(GetSpellTargetUnit()) == 'h002' ) ) then
        return false
    endif
    return true
endfunction

function Trig_detonate_Actions takes nothing returns nothing
    call IssueImmediateOrder( GetSpellAbilityUnit(), "stop" )
endfunction

//===========================================================================
function InitTrig_detonate takes nothing returns nothing
    set gg_trg_detonate = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_detonate, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_detonate, Condition( function Trig_detonate_Conditions ) )
    call TriggerAddAction( gg_trg_detonate, function Trig_detonate_Actions )
endfunction


If I can just get over this hurdle...



Re: Can I request some help please? :)
Reply #6 on: May 23, 2015, 11:04:02 AM

What's the error message??? because as far as I read the code, it doesn't have anything bad.


Re: Can I request some help please? :)
Reply #7 on: May 23, 2015, 11:08:02 AM

Okay so here is what I am seeing:
Unprotected version: not visible in wc3 map list.
Protected version unedited: shows up in the map list with slots.
Protected version edited: shows up in the map list with no slots or "fake slots".
Protected version edited (with trigger disabled): shows up in the map list with slots.



Re: Can I request some help please? :)
Reply #8 on: May 23, 2015, 11:56:56 AM

So you're trying to edit a protected map?

Protecting any WC3 implies that WE content in the map is removed and only the files for running the map are kept. This implies that most of the content will appear as removed (or as you can see, empty slots).


Re: Can I request some help please? :)
Reply #9 on: May 23, 2015, 12:09:51 PM

I have an unprotected ver... that is a list of different results when I try to open in wc3. That is the "error" I am getting. The map either won't show up on the list or it will but the slots are not there and if they do show up you cant change them. If I click start map it tries, then goes right back to the maps list. I use Vexorians optimizer ver 5.0. In the maps current state I will be unable to "test" the map from the editor without optimizing it you see...

I should have started out with at least a little background on myself. No much of a bragger so I will make it short. I am the creator of Lazerus TD and a few other maps, been mapping for a long time, got out of it for a while but got a chance to get back in. wc3 forever!
« Last Edit: May 23, 2015, 02:17:28 PM by Lazerus »



Re: Can I request some help please? :)
Reply #10 on: May 23, 2015, 12:23:40 PM

Everything so true so far, he has the open version and my permission to edit it.
My solution: click away those errors when UMSWE loads up, and you can actually work with the map.
The open version not visible in WC3 isn't actually a problem for me, since i'm not planning to give it out to the public.



Re: Can I request some help please? :)
Reply #11 on: May 23, 2015, 04:04:03 PM

Quote
My solution: click away those errors when UMSWE loads up, and you can actually work with the map.
The open version not visible in WC3 isn't actually a problem for me, since i'm not planning to give it out to the public.

I no longer have the errors we talked about at the beginning, that was a conflict between the 2 editors (not only were they different errors, I was only asking you about them as a troubleshooting technique to see if it was me or both of us). I am 30 steps past that right now. The info about the map not being able to load unprotected is an issue for me because it is valid information for this type of troubleshooting. I am not familiar with this editor and do not know if that is common or if it is something lingering in the map that could be causing the issue. The problem is not about just editing the map like units or spells, it is specifically changing or adding something in the trigger editor.
« Last Edit: May 23, 2015, 04:44:36 PM by Lazerus »



Re: Can I request some help please? :)
Reply #12 on: May 25, 2015, 03:41:52 AM

Moyack, what ways are there to get the map to load without using UMSWE?



Re: Can I request some help please? :)
Reply #13 on: May 25, 2015, 08:41:27 AM

  • Make a copy of your map (just in case) and convert ALL the triggers with USMWE features into custom text.
  • Save the map.
  • Disable USMWE.
  • Close WE and restart it.
  • Open your map and check if it opens.


Voila.

If there's any issue, just let me know.


Re: Can I request some help please? :)
Reply #14 on: May 25, 2015, 10:46:48 AM

I converted ALL the triggers to custom text, saved the map, disabled USMWE, closed the editor, opened the editor, tried to open the map. Crash. The error said "Trigger function does not exist in database: IssueImmediateOrderByID". This is the error I was asking @RaptorXI about. But it did that on the first trigger, there are 120 more triggers for it to possible error on. 1/120

Another thing I tried was finding a trigger that was already in the map and add DoNothing to it (save optimize all that jazz) still wont show up in wc3.

This is the trigger that is in the map that I added it to:
Code: [Select]
Bring out your dead
    Events
        Unit - A unit Dies
    Conditions
    Actions
        Wait 2.00 seconds
        Unit - Remove (Dying unit) from the game
I made it into this:
Code: [Select]
Bring out your dead
    Events
        Unit - A unit Dies
    Conditions
    Actions
        Wait 2.00 seconds
        Unit - Remove (Dying unit) from the game
        Do nothing
Then I converted to custom text, plus every other trigger and saved optimized tried to play the map from wc3... Not happening.

Here is the problem: Any edit to any trigger makes the map unplayable.



Re: Can I request some help please? :)
Reply #15 on: May 27, 2015, 03:35:28 AM

I want to see at shit myself.
Lazerus, stop making new triggers, you were told what to do:

  • Make a copy of your map (just in case) and convert ALL the triggers with USMWE features into custom text.
  • Save the map.
  • Disable USMWE.
  • Close WE and restart it.
  • Open your map and check if it opens.


Voila.

If there's any issue, just let me know.

I want to look at that shit myself too.

How to see which triggers are made with UMSWE? And wow to convert them into custom text?



Re: Can I request some help please? :)
Reply #16 on: May 27, 2015, 10:26:24 AM

Excuse me dude? I did exactly what he asked. This is the second time you have gotten an attitude with me. You are not my boss and I don't need to be helping you. I didn't add "new triggers" I am troubleshooting. Infact, why don't you figure it out yourself and good luck getting someone to help you acting like that. Good bye. Thank you moyack for your time. Im out.



Re: Can I request some help please? :)
Reply #17 on: May 27, 2015, 10:46:27 AM

Please calm down, remember that this is not an easy thing to do. Just don't extend a bad attitude and we could try to help you as much as possible.


Re: Can I request some help please? :)
Reply #18 on: May 27, 2015, 11:18:44 AM

I will show a bit of the Code then.
For example, there a is trigger called "No Ally Attack":

Quote
function Trig_No_Ally_Attack_Conditions takes nothing returns boolean
    return IsUnitAlly(GetAttacker(), GetOwningPlayer(GetTriggerUnit())) == true
endfunction

function Trig_No_Ally_Attack_Actions takes nothing returns nothing
    call IssueImmediateOrder( GetAttacker(), "stop" )
endfunction

//===========================================================================
function InitTrig_No_Ally_Attack takes nothing returns nothing
    set gg_trg_No_Ally_Attack = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventDK( gg_trg_No_Ally_Attack, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_No_Ally_Attack, Condition( function Trig_No_Ally_Attack_Conditions ) )
    call TriggerAddAction( gg_trg_No_Ally_Attack, function Trig_No_Ally_Attack_Actions )
endfunction

Is this a UMSWE feature? Is it not?
How to see such things?



Re: Can I request some help please? :)
Reply #19 on: May 27, 2015, 11:54:37 AM

I converted all the triggers to custom text. The map still didn't work. I HATE repeating myself but you just don't seem to retain information. I have had to go over it with you many times and you still don't get it. I have spent hours with you teaching you things about the editor even video chat to help you. I will not help someone who does not appreciate it.

Quote
function Trig_No_Ally_Attack_Conditions takes nothing returns boolean
    return IsUnitAlly(GetAttacker(), GetOwningPlayer(GetTriggerUnit())) == true
endfunction

function Trig_No_Ally_Attack_Actions takes nothing returns nothing
    call IssueImmediateOrder( GetAttacker(), "stop" )
endfunction

//===========================================================================
function InitTrig_No_Ally_Attack takes nothing returns nothing
    set gg_trg_No_Ally_Attack = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventDK( gg_trg_No_Ally_Attack, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_No_Ally_Attack, Condition( function Trig_No_Ally_Attack_Conditions ) )
    call TriggerAddAction( gg_trg_No_Ally_Attack, function Trig_No_Ally_Attack_Actions )
endfunction

That is already converted to custom text.



Re: Can I request some help please? :)
Reply #20 on: May 27, 2015, 12:17:13 PM

You said you want to help:
https://entgaming.net/forum/viewtopic.php?f=27&t=53495&start=15#p234195
Either keep your word or get out of my map.

My simple question is:
How can I see which triggers were written with UMSWE?




Re: Can I request some help please? :)
Reply #21 on: May 28, 2015, 07:40:44 AM

My simple question is:
How can I see which triggers were written with UMSWE?


Well, all the GUI triggers that have the Get/Set Handle stuff (to set and get the id of objects in WC3) should be the ones to convert into custom text.

I'll try to get the list of these triggers...
« Last Edit: May 28, 2015, 08:04:13 AM by moyack »



Re: Can I request some help please? :)
Reply #22 on: May 30, 2015, 07:42:58 AM

Doesn't matter what triggers they are until we find out if that was what was causing the problem.
When you convert them all and save, optimize and try to play it, you cant, so the trigger thing is not the problem. If it was I would go back to the map and find out what trigger it was. I know what I am doing.

I don't know how many more times I can type this before I explode.

ANY EDIT TO ANY ENABLED TRIGGER CAUSES THE MAP TO BE UNPLAYABLE.

Take it or leave it. Im done.



Re: Can I request some help please? :)
Reply #23 on: May 30, 2015, 08:01:01 PM

CAn you send me the map? so I can give a hand on this and try to help you out?

Send me a link to the map via PM


Re: Can I request some help please? :)
Reply #24 on: May 30, 2015, 08:07:28 PM

I am no longer working with RaptorXI. I really could have jumped into this project with both feet but I can not handle working with unprofessional people. Maybe he will send you the map but I deleted mine. My whole thing for replying is to cut it off clean. I did everything I could and now it is time to move on. Moyack, I am sorry I wasted your time but I appreciate your help.



 

Vivir aprendiendo.co - A place for learning stuff, in Spanish   Chaos Realm - The world of Game modders and wc3 addicts   Diplo, a gaming community   Power of Corruption, an altered melee featuring Naga and Demon. Play it now!!!   WC3JASS.com - The JASS Vault + vJASS and Zinc   Jetcraft - A Starcraft II mod   WormTastic Clan (wTc)